Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: receiver precedence #1742

Merged
merged 17 commits into from
Feb 13, 2025
Merged

tests: receiver precedence #1742

merged 17 commits into from
Feb 13, 2025

Conversation

jeshecdom
Copy link
Contributor

Issue

Closes #1741.

Checklist

  • I have updated CHANGELOG.md
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@jeshecdom jeshecdom requested a review from a team as a code owner February 7, 2025 14:18
@anton-trunov anton-trunov self-assigned this Feb 8, 2025
@anton-trunov anton-trunov added this to the v1.6.0 milestone Feb 8, 2025
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's rename the strings for receiverKind according to the BinaryReceiverSelector type.

  2. we also need to test precedence for bounce and external receivers

src/test/e2e-emulated/contracts/receiver-precedence.tact Outdated Show resolved Hide resolved
src/test/e2e-emulated/contracts/receiver-precedence.tact Outdated Show resolved Hide resolved
}

receive("message") {
self.receiverKind = "message";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.receiverKind = "message";
self.receiverKind = "comment";

src/test/e2e-emulated/contracts/receiver-precedence.tact Outdated Show resolved Hide resolved
src/test/e2e-emulated/contracts/receiver-precedence.tact Outdated Show resolved Hide resolved
@anton-trunov
Copy link
Member

Let's also document the precedence in the Tact docs

Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anton-trunov anton-trunov merged commit 32c8598 into main Feb 13, 2025
25 checks passed
@anton-trunov anton-trunov deleted the test-receiver-precedence branch February 13, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add precedence tests on receivers
3 participants