Merge taataa/release-alpha23

Release alpha23

docs/api/v2/generate.js

@@ -95,6 +95,7 @@ yamdog.generate({
       'dist3': affineplaneDocs + '#affineplanedist3',
       'helm2': affineplaneDocs + '#affineplanehelm2',
       'helm3': affineplaneDocs + '#affineplanehelm3',
+      'orient2': affineplaneDocs + '#affineplaneorient2',
       'path2': affineplaneDocs + '#affineplanepath2',
       'path3': affineplaneDocs + '#affineplanepath3',
       'plane2': affineplaneDocs + '#affineplaneplane2',

docs/api/v2/index.md

@@ -1,5 +1,5 @@
 <a name="top"></a>
-# Tapspace API Documentation v2.0.0-alpha.22
+# Tapspace API Documentation v2.0.0-alpha.23
 
 
 Choose version: [v1](https://taataa.github.io/tapspace/api/) – [v2](#)
@@ -1414,7 +1414,7 @@ Create an [Orientation](#tapspacegeometryorientation) on this basis.
 <p style="margin-bottom: 0"><strong>Parameters:</strong></p>
 
 - *angle*
-  - a number or orient2 object { a, b }
+  - a number or [orient2](https://axelpale.github.io/affineplane/docs/API.html#affineplaneorient2) object { a, b }
 
 
 <p style="margin-bottom: 0"><strong>Returns:</strong></p>
@@ -7565,7 +7565,7 @@ space and therefore they need conversion when transited between bases.
 - *basis*
   - a [Component](#tapspacecomponentscomponent)
 - *orient*
-  - a orient2, or {a,b} relative to the basis.
+  - an [orient2](https://axelpale.github.io/affineplane/docs/API.html#affineplaneorient2) relative to the basis.
 
 
 
@@ -7612,7 +7612,7 @@ Source: [changeBasis.js](https://github.com/taataa/tapspace/blob/master/lib/geom
 <a name="tapspacegeometryorientationgetraw"></a>
 ## [tapspace](#tapspace).[geometry](#tapspacegeometry).[Orientation](#tapspacegeometryorientation):[getRaw](#tapspacegeometryorientationgetraw)()
 
-**Returns:** plain orient2 object `{a,b}` without basis data.
+**Returns:** plain [orient2](https://axelpale.github.io/affineplane/docs/API.html#affineplaneorient2) object `{a,b}` without basis data.
 
 Source: [getRaw.js](https://github.com/taataa/tapspace/blob/master/lib/geometry/Orientation/getRaw.js)
 
@@ -7637,7 +7637,7 @@ Unlike changeBasis, returns a plain object without basis data.
 
 <p style="margin-bottom: 0"><strong>Returns:</strong></p>
 
-- a orient2, complex number
+- an [orient2](https://axelpale.github.io/affineplane/docs/API.html#affineplaneorient2)
 
 
 Source: [transitRaw.js](https://github.com/taataa/tapspace/blob/master/lib/geometry/Orientation/transitRaw.js)
@@ -7657,7 +7657,7 @@ See [Point:transitRawOuter](#tapspacegeometrypointtransitrawouter) for details.
 
 <p style="margin-bottom: 0"><strong>Returns:</strong></p>
 
-- a orient2, complex number
+- an [orient2](https://axelpale.github.io/affineplane/docs/API.html#affineplaneorient2)
 
 
 Source: [transitRawOuter.js](https://github.com/taataa/tapspace/blob/master/lib/geometry/Orientation/transitRawOuter.js)

lib/components/Hyperspace/rotateBy.js

@@ -15,6 +15,11 @@ module.exports = function (radians, pivot) {
   //   this, for chaining
   //
 
+  // Detect invalid radians: NaN, string
+  if (typeof radians !== 'number' || isNaN(radians)) {
+    throw new Error('Invalid rotation angle: ' + radians)
+  }
+
   // Normalize the origin.
   if (pivot.transitRaw) {
     pivot = pivot.transitRaw(this)

lib/components/Hyperspace/scaleBy.js

@@ -15,6 +15,11 @@ module.exports = function (multiplier, pivot) {
   //   this, for chaining
   //
 
+  // Detect invalid multiplier: NaN, string, zero
+  if (!multiplier || typeof multiplier !== 'number') {
+    throw new Error('Invalid scale multiplier: ' + multiplier)
+  }
+
   // Normalize the origin.
   if (pivot.transitRaw) {
     pivot = pivot.transitRaw(this)

lib/components/Node/getBoundingBox.js

@@ -24,7 +24,7 @@ module.exports = function (orientation) {
   let orient
   if (orientation.getOrientation) {
     // Is Component or Basis
-    orient = orientation.getOrientation.transitRaw(this)
+    orient = orientation.getOrientation().transitRaw(this)
   } else {
     // Is Orientation or errors
     orient = orientation.transitRaw(this)

lib/components/Transformer/rotateBy.js

@@ -16,6 +16,11 @@ module.exports = function (radians, pivot) {
   //   this, for chaining
   //
 
+  // Detect invalid radians: NaN, string
+  if (typeof radians !== 'number' || isNaN(radians)) {
+    throw new Error('Invalid rotation angle: ' + radians)
+  }
+
   // Normalize the anchor point.
   const anchor = this.atAnchor(pivot)
 

lib/components/Transformer/scaleBy.js

@@ -16,6 +16,11 @@ module.exports = function (multiplier, pivot) {
   //   this, for chaining
   //
 
+  // Detect invalid multiplier: NaN, string, zero
+  if (!multiplier || typeof multiplier !== 'number') {
+    throw new Error('Invalid scale multiplier: ' + multiplier)
+  }
+
   // Normalize the anchor point.
   pivot = this.atAnchor(pivot)
 

lib/geometry/Basis/rotateBy.js

@@ -16,6 +16,11 @@ module.exports = function (radians, origin) {
   //   a Basis, the rotated basis
   //
 
+  // Detect invalid radians: NaN, string
+  if (typeof radians !== 'number' || isNaN(radians)) {
+    throw new Error('Invalid rotation angle: ' + radians)
+  }
+
   // Normalize
   if (!origin) {
     origin = { x: this.tran.x, y: this.tran.y, z: this.tran.z }

lib/geometry/Basis/scaleBy.js

@@ -16,6 +16,11 @@ module.exports = function (multiplier, origin) {
   //   a Basis, the scaled basis
   //
 
+  // Detect invalid multiplier: NaN, string, zero
+  if (!multiplier || typeof multiplier !== 'number') {
+    throw new Error('Invalid scale multiplier: ' + multiplier)
+  }
+
   // Normalize
   if (!origin) {
     origin = { x: this.tran.x, y: this.tran.y, z: this.tran.z }

lib/geometry/Box/rotateBy.js

@@ -16,6 +16,11 @@ module.exports = function (radians, origin) {
   //   a Box, the rotated box
   //
 
+  // Detect invalid radians: NaN, string
+  if (typeof radians !== 'number' || isNaN(radians)) {
+    throw new Error('Invalid rotation angle: ' + radians)
+  }
+
   // Normalize
   if (origin.transitRaw) {
     origin = origin.transitRaw(this.basis)

lib/geometry/Box/scaleBy.js

@@ -16,6 +16,11 @@ module.exports = function (multiplier, origin) {
   //   a Box, the scaled box
   //
 
+  // Detect invalid multiplier: NaN, string, zero
+  if (!multiplier || typeof multiplier !== 'number') {
+    throw new Error('Invalid scale multiplier: ' + multiplier)
+  }
+
   // The origin needs to be transited into outer basis of the box
   // for the affineplane scaleBy to work.
   // The outer basis of the box is the inner basis of Box... x_x

lib/geometry/Orientation/index.js

@@ -13,7 +13,7 @@ const Orientation = function (basis, orient) {
   //   basis
   //     a Component
   //   orient
-  //     a orient2, or {a,b} relative to the basis.
+  //     an orient2 relative to the basis.
   //
 
   // DEBUG

lib/geometry/Orientation/transitRaw.js

@@ -11,7 +11,7 @@ module.exports = function (newBasis) {
   //     a Component
   //
   // Return
-  //   a orient2, complex number
+  //   an orient2
   //
   const tran = this.basis.getTransitionTo(newBasis)
   return orient2.transitFrom(this.orient, tran)

lib/geometry/Orientation/transitRawOuter.js

@@ -12,7 +12,7 @@ module.exports = function (basis) {
   //     a Component
   //
   // Return
-  //   a orient2, complex number
+  //   an orient2
   //
   const tran = this.basis.getTransitionToParentOf(basis)
   return orient2.transitFrom(this.orient, tran)

package.json

@@ -1,6 +1,6 @@
 {
   "name": "tapspace",
-  "version": "2.0.0-alpha.22",
+  "version": "2.0.0-alpha.23",
   "description": "A zoomable user interface lib for web apps",
   "keywords": [
     "zoomable",