Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tuple struct field public #32

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Make tuple struct field public #32

merged 1 commit into from
Feb 20, 2024

Conversation

DavisVaughan
Copy link
Contributor

Closes #31

So you can create instances of the tuple struct itself

@DavisVaughan
Make tuple struct field public
0d6c31c 
So you can create instances of the tuple struct itself
@sztomi sztomi self-requested a review February 20, 2024 16:55
sztomi
sztomi approved these changes Feb 20, 2024
View reviewed changes
Copy link
Owner

@sztomi sztomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good catch! Thank you! 🙏

@sztomi sztomi merged commit 913a2a5 into sztomi:main Feb 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sztomi sztomi sztomi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should pub struct CustomValue(Value) be pub struct CustomValue(pub Value)?
2 participants
@DavisVaughan @sztomi