-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provisioning): add cloudformation templates and related GHA #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trator-agent and the instrumentation stack Signed-off-by: francesco-racciatti <[email protected]>
Signed-off-by: francesco-racciatti <[email protected]>
d554f88
to
0f1139b
Compare
9ef750f
to
12114df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from one question. I wonder if we need to include the RC image tag in the CFT so QE can pull that to test.
The release action will be used to make rc tags and prereleases that will be eventually promoted. The rc distributes two attachments: - cloudformation.zip containing the cloudformation templates versioned by the prerelease action - checksum.txt containing the checksum of the resources attached to the prerelease The agent-kilt golang executable is no longer distributed. It will be replaced by a docker image. Signed-off-by: francesco-racciatti <[email protected]>
This action promotes the target RC tag and creates a release (marked as latest) based on it. Signed-off-by: francesco-racciatti <[email protected]>
12114df
to
26738d6
Compare
pgcrooks-sysdig
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes CloudFormation templates for deploying the serverless agent and adds the related GitHub Actions to facilitate the creation of RC tags and pre-releases, as well as the promotion of release candidates.
Actions are provided with a workflow_dispatch to be triggered via CI.
Furthermore, the agent-kilt golang executable is no longer distributed. It will be replaced by a docker image.
Best reviewed commit-by-commit.