Nameforalias txlist #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddress for this command to work. if alias value doesnt containa syscoin address, command will fail.
This allows any address used as an alias, so any calls (internal, external via rpc) can be used with alias names as a dropin replacement for a syscoin address... ie: sendtoalias is not needed, sendtoaddress does what we need.
You can save aliases in the address book from send coin tab.. it will save the alias address. You can send coins to an alias and it will resolve the address before sending.
When adding to address book wallet is locked but in our GetAliasAddress we were locking again, causing a deadlock.... I suggest we review anywhere we use service functions anywhere but RPC calls as they may be double locking and causing (wallet hang bugs as reported by people).. I use TRY_LOCK which DOESN"T lock if its already locked, so I suggest in our services to use TRY_LOCK everywhere, coderboo to review. Removed sendtoalias, not needed.
selectively merged in changes from qt-myalias branch and fixed up slow loading of "my aliases" uses mapwallet now.
1) If label is empty and address is a alias, set label to alias name (including when paying out) 2) Try to fix update issue, should notify when tx is recieved (rpc console updates qt gui) 3) Bitcoin doesn't like O I l characters in its address but they are valid for aliases, so remove this restriction for syscoin addresses/aliases... 4) max chars for address is 1023 now to follow alias convention 5) Try to fix duplicate aliases issue in my alias tab
…s aliasactivate and aliasupdate do.
dwasyluk
force-pushed
the
devstaging-0.1.5
branch
from
85db145 to
13a7ef1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.