Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the color scheme of the alerts to increase contrast #141

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

DerGeras
Copy link
Collaborator

@DerGeras DerGeras commented Oct 20, 2023

This is based on contrast ratio, staying close to the recommendations for visual-audio contrast recommendations from W3C (minimum 4.5:1 for small text, 7:1 for small text and users with a lower visual acuity). Red alerts stayed the same bright red for now, as the emphasis is for the alert to be immedialty recognized as important, but changed the text color from white to black for better contrast.

Note that I removed the opacity, as it was actually changing the opacity of the whole alert, instead of just changing the text opacity. I do not know if that was intended or not.

Looking at the examples below, I would highly appreciate a proposition for a different "red", as it still feels a bit hard on the eyes.

Before:
image

After changes:
image

W3C source:
https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html

This is based on contrast ratio, staying close to the recommendations for visual-audio contrast recommendations from W3C (minimum 4.5:1 for small text, 7:1 for small text and users with a lower visual acuity).
Red alerts stayed the same bright red for now, as the emphasis is for the alert to be immedialty recognized as important, but changed the text color from white to black for better contrast.
@DerGeras
Copy link
Collaborator Author

After a bit more playing around with the color slider, I found a more satisfying colour:
image

It still does feel a bit strange to do this the feelycraft way of adjusting and checking.

Copy link
Member

@BuJo BuJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with that.

@BuJo BuJo merged commit 91ee686 into main Oct 23, 2023
@BuJo BuJo deleted the recolor-alerts branch October 23, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants