Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update syncLdk Method #241

Merged
merged 1 commit into from
May 21, 2024
Merged

Update syncLdk Method #241

merged 1 commit into from
May 21, 2024

Conversation

coreyphillips
Copy link
Collaborator

@coreyphillips coreyphillips commented May 20, 2024 •
edited
Loading

This PR:

  • Updates syncLdk method.
    • Ensures syncToTip is always run.
    • Ensures checkWatchTxs, checkWatchOutputs & checkUnconfirmedTransactions all get an opportunity to run instead of returning with an error early.
    • Adds finally to ensure the code block is always run.
  • Remove forceSync from LightningManager class.
  • Remove handleForceSync method from LightningManager class.

@coreyphillips
Update syncLdk.
952a7db 
Remove forceSync from LightningManager class.
Remove handleForceSync method from LightningManager class.
@coreyphillips coreyphillips requested a review from Jasonvdb May 20, 2024 16:08
@coreyphillips coreyphillips self-assigned this May 20, 2024
Jasonvdb
Jasonvdb approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@Jasonvdb Jasonvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine my side just can't get the android GH action to pass

@Jasonvdb Jasonvdb merged commit 4125f00 into master May 21, 2024
6 checks passed
@Jasonvdb Jasonvdb deleted the update-syncLdk branch May 21, 2024 11:20
@Jasonvdb Jasonvdb mentioned this pull request May 23, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jasonvdb Jasonvdb Jasonvdb approved these changes

Assignees

@coreyphillips coreyphillips

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coreyphillips @Jasonvdb