Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): #1733 avoid duplicate notification for received onchain tx #2460

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Feb 6, 2025

Description

Persist receivedTxIds to mmkv to avoid showing duplicate notifications when electrum connection is re-established. I could've added this to redux but opted to just write straight to storage to avoid redux ceremony until we have a use case. Also removed unused logic in refreshWallet around notifications that doesn't seem to be used anymore and cleaned up default params.

Linked Issues/Tasks

Closes #1733

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

@pwltr pwltr requested a review from coreyphillips February 6, 2025 18:03
@pwltr pwltr merged commit 4da383e into master Feb 7, 2025
7 checks passed
@pwltr pwltr deleted the fix/receive-notif branch February 7, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Receive confetti displays for old transaction when Electrum reconnects
2 participants