LISTNAME-request@DOMAIN aliases are not supported (#1922)

sympa-community · Jan 23, 2025 · cf90aca · cf90aca
1 parent afbc496
commit cf90aca
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 13 deletions.
diff --git a/src/lib/Sympa/Aliases/CheckSMTP.pm b/src/lib/Sympa/Aliases/CheckSMTP.pm
@@ -48,11 +48,10 @@ sub check {
         || $smtp_relay;
     $smtp_helo =~ s/:[-\w]+$// if $smtp_helo;
 
-    my @suffixes = split /\s*,\s*/,
-        (Conf::get_robot_conf($robot_id, 'list_check_suffixes') || '');
     my @addresses = (
         sprintf('%s@%s', $name, $robot_id),
-        map { sprintf('%s-%s@%s', $name, $_, $robot_id) } @suffixes
+        map { sprintf('%s-%s@%s', $name, $_, $robot_id) }
+            @{Conf::get_robot_conf($robot_id, 'list_check_suffixes') // []}
     );
     my $return_address = sprintf '%s%s@%s', $name,
         (Conf::get_robot_conf($robot_id, 'return_path_suffix') || ''),

diff --git a/src/lib/Sympa/List/Users.pm b/src/lib/Sympa/List/Users.pm
@@ -198,9 +198,8 @@ use constant _local_validations => {
         push @special, map {
             sprintf '%s-%s@%s',
                 $list->{'name'}, lc $_, $list->{'domain'}
-            }
-            split /[,\s]+/,
-            Conf::get_robot_conf($list->{'domain'}, 'list_check_suffixes');
+        } @{Conf::get_robot_conf($list->{'domain'}, 'list_check_suffixes')
+                // []};
         my $bounce_email_re = quotemeta($list->get_bounce_address('ANY'));
         $bounce_email_re =~ s/(?<=\\\+).*(?=\\\@)/.*/;
 

diff --git a/src/lib/Sympa/Spool.pm b/src/lib/Sympa/Spool.pm
@@ -332,14 +332,9 @@ sub split_listname {
 
     my $return_path_suffix =
         Conf::get_robot_conf($robot_id, 'return_path_suffix');
-    my $regexp = join(
-        '|',
+    my $regexp = join '|',
         map { quotemeta $_ }
-            grep { $_ and length $_ }
-            split(
-            /[\s,]+/, Conf::get_robot_conf($robot_id, 'list_check_suffixes')
-            )
-    );
+        @{Conf::get_robot_conf($robot_id, 'list_check_suffixes') // []};
 
     if (    $mailbox eq 'sympa'
         and $robot_id eq $Conf::Conf{'domain'}) {    # compat.