bug #2590 [StimulusBundle] Fix lazy load Stimulus controllers with Tu…

…rbo (smnandre) This PR was merged into the 2.x branch. Discussion ---------- [StimulusBundle] Fix lazy load Stimulus controllers with Turbo | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no  | Issues | Fix #2576 / maybe #2583 | License | MIT Partial revert of some changes to fix issues with Turbo and lazyload Stimulus controllers Commits ------- 111fd4c fix: lazy load Stimulus controllers with Turbo
symfony · Feb 24, 2025 · 6d2daab · 6d2daab
2 parents d677450 + 111fd4c
commit 6d2daab
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 29 deletions.
diff --git a/src/StimulusBundle/assets/dist/loader.js b/src/StimulusBundle/assets/dist/loader.js
@@ -53,22 +53,17 @@ class StimulusLazyControllerHandler {
             return;
         }
         new MutationObserver((mutationsList) => {
-            for (const mutation of mutationsList) {
-                switch (mutation.type) {
-                    case 'childList': {
-                        for (const node of mutation.addedNodes) {
-                            if (node instanceof Element) {
-                                extractControllerNamesFrom(node).forEach((controllerName) => {
-                                    this.loadLazyController(controllerName);
-                                });
-                            }
+            for (const { attributeName, target, type } of mutationsList) {
+                switch (type) {
+                    case 'attributes': {
+                        if (attributeName === controllerAttribute &&
+                            target.getAttribute(controllerAttribute)) {
+                            extractControllerNamesFrom(target).forEach((controllerName) => this.loadLazyController(controllerName));
                         }
                         break;
                     }
-                    case 'attributes': {
-                        if (mutation.attributeName === controllerAttribute) {
-                            extractControllerNamesFrom(mutation.target).forEach((controllerName) => this.loadLazyController(controllerName));
-                        }
+                    case 'childList': {
+                        this.lazyLoadExistingControllers(target);
                     }
                 }
             }

diff --git a/src/StimulusBundle/assets/src/loader.ts b/src/StimulusBundle/assets/src/loader.ts
@@ -99,26 +99,23 @@ class StimulusLazyControllerHandler {
             return;
         }
         new MutationObserver((mutationsList) => {
-            for (const mutation of mutationsList) {
-                switch (mutation.type) {
-                    case 'childList': {
-                        // @ts-ignore
-                        for (const node of mutation.addedNodes) {
-                            if (node instanceof Element) {
-                                extractControllerNamesFrom(node).forEach((controllerName) => {
-                                    this.loadLazyController(controllerName);
-                                });
-                            }
-                        }
-                        break;
-                    }
-
+            for (const { attributeName, target, type } of mutationsList) {
+                switch (type) {
                     case 'attributes': {
-                        if (mutation.attributeName === controllerAttribute) {
-                            extractControllerNamesFrom(mutation.target as Element).forEach((controllerName) =>
+                        if (
+                            attributeName === controllerAttribute &&
+                            (target as Element).getAttribute(controllerAttribute)
+                        ) {
+                            extractControllerNamesFrom(target as Element).forEach((controllerName) =>
                                 this.loadLazyController(controllerName)
                             );
                         }
+
+                        break;
+                    }
+
+                    case 'childList': {
+                        this.lazyLoadExistingControllers(target as Element);
                     }
                 }
             }