Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS fixes #1037

Merged
merged 1 commit into from
Feb 7, 2025
Merged

CS fixes #1037

merged 1 commit into from
Feb 7, 2025

Conversation

rosier
Copy link
Contributor

@rosier rosier commented Feb 3, 2025

I did split this in separate commits to make it easier to review.

I can squash this if you prefer that.

@rosier
Copy link
Contributor Author

rosier commented Feb 3, 2025

The fabbot suggests a few more changes but I not sure if all work on PHP 7.1

@rosier
Copy link
Contributor Author

rosier commented Feb 5, 2025

The fabbot suggest one more change but that requires PHP 8

-                if (0 === strpos(\get_class($plugin), 'Hirak\Prestissimo\Plugin')) {
+                if (0 === strpos($plugin::class, 'Hirak\Prestissimo\Plugin')) {

@fabpot
Copy link
Member

fabpot commented Feb 7, 2025

Thank you @rosier.

@fabpot fabpot merged commit a7a37d9 into symfony:1.x Feb 7, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants