Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup! purescript: refactor #14602

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

lebensterben
Copy link
Contributor

spacemacs|add-company-backends is a macro, so arguments are taken as-is, instead of being evaluated.

The previous refactor would not cause error, but it would not work either.

The arguments to :backends must take the form of:

  • One or multiple unquoted symbol
  • A list of symbol
  • Lists of symbols

@duianto
Copy link
Contributor

duianto commented Apr 5, 2021

The Validate PR test failed with the message: Please rebase your PR

No action is required, the following command rebases it automatically.
/rebase

Update:
Or at least I assumed it would.
Since it happened here: #14581 (comment)
and even when it was written in a quote: #14581 (comment)

Copy link
Collaborator

@smile13241324 smile13241324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok, will be merged in a minute.

@smile13241324 smile13241324 merged commit b0dc044 into syl20bnr:develop Apr 5, 2021
@lebensterben lebensterben deleted the bugfix-purescript branch April 17, 2021 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants