Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch the phpcbf package directly from github #14574

Closed
wants to merge 1 commit into from

Conversation

bystrano
Copy link

The phpcbf package is not available on Melpa anymore, it needs to be fetched from Github.

It is not available on Melpa anymore.
@duianto
Copy link
Contributor

duianto commented Mar 31, 2021

There is another PR:
[+layer/php] Fix missed packages #14581

That proposes removing the two unmaintained php packages:

  • phpcbf
  • php-auto-yasnippet

I don't know if it's better to get them from their archived github pages,
or to remove them from the php layer.

There's an open issue about it here:
Packages 'php-auto-yasnippet' and 'phpcbf' in php layer unavailable #14381

@bystrano
Copy link
Author

bystrano commented Apr 1, 2021

After giving this more thought, I think this package should be removed from spacemacs.

It is a wrapper around a formatting tool. But code formatting is also provided by LSP, which has better support and is the way forward.
Keeping this package in spacemacs would duplicate functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants