-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic static properties + asynchronous inference algorithm #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… them into inference.
…handling mechanisms.
This was referenced Sep 1, 2024
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we are introducing two main concepts:
We are adding support for writing custom static properties as first-order formulas. There is a new tokenizer, parser, and evaluator for these formulas. They are directly added to the inference process, and also to the consistency validation check.
We will make a guide on formula writing in the future. Just as an example of how one can reason about uninterpreted or update functions:
\exists x, y: f(0, x) ^ h(x, y)
to describe some complex relationship between functionsf
andh
\forall x, y: f_v3(0, x, y) => f_v3(1, x, y)
to say variablev1
activatesv3
(if we have a variablev3
with three regulatorsv1
,v2
,v3
)The whole inference computation now runs completely asynchronously. This means it no longer blocks the main backend thread. It now also reports progress to the front end and is partially cancellable (in particular checkpoints, such as just before starting the evaluation of some property). We also added error handling to the inference process. The symbolic context for each computation is now created automatically based on the properties. Different symbolic contexts are used for different kinds of properties.