-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation of SBML rules for MathML #21
Conversation
- add skeleton for rule 10214
- add utility function for extraction of identifiers of function definitions - add utility function to convert `XmlList<T>` into `Vec<T>`
- prototype
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
===========================================
+ Coverage 51.46% 78.52% +27.06%
===========================================
Files 38 40 +2
Lines 855 1509 +654
===========================================
+ Hits 440 1185 +745
+ Misses 415 324 -91 ☔ View full report in Codecov by Sentry. |
- handle the case when a compartment cannot be found
- improve validation mechanism by generalization of frequently used functions - remove code duplication to some extent
563cd32
to
2175e2a
Compare
- two missing identifiers would be considered as two empty ("") identifiers and thus duplicates
d6844b1
to
782e74f
Compare
757c892
to
6ebc5ec
Compare
- only children from core namespace must be loaded
- check that required children and attributes are set
- check that attribute values are of the correct type
# Conflicts: # src/core/validation/model.rs
I decided to push sanity checks along with the already implemented validation rules (10301 through 10304), as there are only 4 new rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is now ready to merge. Not all rules work 100% correctly, but we can fix that later since we now have the test suite.
No description provided.