Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of SBML rules for MathML #21

Merged
merged 59 commits into from
Feb 25, 2024
Merged

Validation of SBML rules for MathML #21

merged 59 commits into from
Feb 25, 2024

Conversation

SolunarNexus
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: Patch coverage is 79.17146% with 181 lines in your changes are missing coverage. Please review.

Project coverage is 78.52%. Comparing base (38017e0) to head (dd8d655).
Report is 3 commits behind head on main.

Files Patch % Lines
examples/test-suite-syntactic.rs 0.00% 105 Missing ⚠️
src/core/validation/math.rs 82.41% 48 Missing ⚠️
src/core/model.rs 89.41% 9 Missing ⚠️
src/core/validation/mod.rs 90.36% 8 Missing ⚠️
examples/basic_example.rs 0.00% 4 Missing ⚠️
src/core/sbase.rs 87.50% 2 Missing ⚠️
src/xml/impl_xml_property_type.rs 75.00% 2 Missing ⚠️
src/xml/xml_list.rs 93.75% 2 Missing ⚠️
src/xml/xml_wrapper.rs 97.91% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #21       +/-   ##
===========================================
+ Coverage   51.46%   78.52%   +27.06%     
===========================================
  Files          38       40        +2     
  Lines         855     1509      +654     
===========================================
+ Hits          440     1185      +745     
+ Misses        415      324       -91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SolunarNexus and others added 5 commits February 17, 2024 10:15
- handle the case when a compartment cannot be found
- improve validation mechanism by generalization of frequently used functions
- remove code duplication to some extent
@SolunarNexus
Copy link
Contributor Author

I decided to push sanity checks along with the already implemented validation rules (10301 through 10304), as there are only 4 new rules

Copy link
Member

@daemontus daemontus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is now ready to merge. Not all rules work 100% correctly, but we can fix that later since we now have the test suite.

@SolunarNexus SolunarNexus merged commit 8d65f65 into main Feb 25, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants