Verify host update with tests

sxwei123 · Oct 12, 2022 · abc6c45 · abc6c45
1 parent dc938b8
commit abc6c45
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 9 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,2 +1,3 @@
 node_modules
-dist
+dist
+.env
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "azure-log-analytics-data-collector",
-  "version": "2.2.9",
+  "version": "2.2.10",
   "description": "Node.js wrapper for Azure Log Analytics data collector API",
   "main": "./dist/index.js",
   "exports": "./dist/index.js",
@@ -49,4 +49,4 @@
   "dependencies": {
     "node-fetch": "^2.6.7"
   }
-}
+}
diff --git a/src/index.ts b/src/index.ts
@@ -9,7 +9,7 @@ export class DataCollectorClient {
   constructor(
     private readonly workspaceId: string,
     private readonly sharedKey: string,
-    private readonly host: string
+    private readonly host: string | undefined
   ) { }
 
   /**
@@ -56,7 +56,7 @@ export class DataCollectorClient {
       headers["time-generated-field"] = timeGenerated;
     }
 
-    const hostUrl = (this.host === null || this.host.trim() === "") ? "ods.opinsights.azure.com" : "${this.host}";
+    const hostUrl = (this.host === null || this.host === undefined) ? "ods.opinsights.azure.com" : this.host;
     const url = `https://${this.workspaceId}.${hostUrl}/api/logs?api-version=${API_VERSION}`;
 
     const res = await fetch(url, {

diff --git a/test/index.spec.ts b/test/index.spec.ts
@@ -3,9 +3,9 @@ import { DataCollectorClient } from "../src";
 describe("The data collector client", () => {
   const { LOG_ANALYTICS_HOST, LOG_ANALYTICS_AGENT_KEY, LOG_ANALYTICS_WORKSPACE_ID } = process.env;
 
-  if (!LOG_ANALYTICS_HOST || !LOG_ANALYTICS_AGENT_KEY || !LOG_ANALYTICS_WORKSPACE_ID) {
+  if (!LOG_ANALYTICS_AGENT_KEY || !LOG_ANALYTICS_WORKSPACE_ID) {
     throw new Error(
-      "LOG_ANALYTICS_HOST, LOG_ANALYTICS_AGENT_KEY and LOG_ANALYTICS_WORKSPACE_ID are required"
+      "LOG_ANALYTICS_AGENT_KEY and LOG_ANALYTICS_WORKSPACE_ID are required"
     );
   }
   const client = new DataCollectorClient(
@@ -54,7 +54,7 @@ describe("The data collector client", () => {
     const client = new DataCollectorClient(
       LOG_ANALYTICS_WORKSPACE_ID,
       "X" + LOG_ANALYTICS_AGENT_KEY,
-      "x" + LOG_ANALYTICS_HOST
+      LOG_ANALYTICS_HOST
     );
     const res = await client.send("MyLogs", [
       {