Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad link for "set all hook handlers at once" #211

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

cmsetzer
Copy link
Contributor

Description

The hooks section at https://swup.js.org/options/#hooks includes a link that points to localhost. This fixes the bad link.

Checks

  • The PR is submitted to the master branch
  • The code was linted before pushing (npm run lint)
  • All tests are passing (npm run test)
  • New or updated tests are included
  • The documentation was updated as required

Additional information

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for splendorous-kataifi-9ae281 ready!

Name Link
🔨 Latest commit d1e8cdb
🔍 Latest deploy log https://app.netlify.com/sites/splendorous-kataifi-9ae281/deploys/673e8eb1e81e2f0008ed4856
😎 Deploy Preview https://deploy-preview-211--splendorous-kataifi-9ae281.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@hirasso hirasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

@hirasso hirasso merged commit 64dd8ac into swup:master Nov 21, 2024
5 checks passed
@cmsetzer cmsetzer deleted the fix-set-all-hook-handlers-link branch November 22, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants