Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSS - Adjustments to SPS 2025 Implementation Guidelines (issue #141) #143

Open
wants to merge 7 commits into
base: release-v5
Choose a base branch
from

Conversation

simonmeyerm
Copy link
Collaborator

  • Change of address information
    • Removed unstructured address
    • Change required address attributes to "townName" and "country" only
    • Added 2 additional address lines to support hybrid structure
  • Changed max characters for debtor name to 140 and added remark that limitation of 70 characters applies for SEPA payments.

Following an internal discussion with SIX developers, it was concluded that introducing address lines as an array limited to two entries would not provide significant benefit.

- Changes according to issue 141 SPS 2025
@simonmeyerm simonmeyerm requested a review from a team as a code owner December 19, 2024 13:36
@svenbiellmann svenbiellmann linked an issue Dec 20, 2024 that may be closed by this pull request
1 task
@zioerjenthomas
Copy link

hi @simonmeyerm
feedback/proposal regarding the changes (and even existing parts ;)) from my end:

  • proposal for PaymentAddress-title: allign title with pattern: actual "Address for Payments" -> proposal "Payment Postal Address"
  • proposal for PaymentAddress-description:
  • proposal for PaymentAddress-country-description: remove counterparty -> "The country. Corresponds to the attribute Ctry in SPS/ISO-20022."
  • why not defining a specific type for Country/CountryCode as per ISO-20022 to ensure the pattern "[A-Z]{2,2}"? If yes would it make sense to add pattern "[A-Z]{3,3}" to Currency?
  • in the name you added the description "Restriction for payment type SEPA is 70 characters" - would it not make sense to replace "payment type SEPA" with sepaindicator=true (or similar) because payment type does not exist in JSON spec?

- Added suggestions from Thomas Z.
adjustment wording country description
@simonmeyerm
Copy link
Collaborator Author

simonmeyerm commented Jan 22, 2025

hi @simonmeyerm feedback/proposal regarding the changes (and even existing parts ;)) from my end:

  • proposal for PaymentAddress-title: allign title with pattern: actual "Address for Payments" -> proposal "Payment Postal Address"
  • proposal for PaymentAddress-description: "The postal adress of a participant within the payment. Corresponds to the attribute PstlAdr in SPS/ISO-20022.".
  • proposal for PaymentAddress-country-description: remove counterparty -> "The country. Corresponds to the attribute Ctry in SPS/ISO-20022."
  • why not defining a specific type for Country/CountryCode as per ISO-20022 to ensure the pattern "[A-Z]{2,2}"? If yes would it make sense to add pattern "[A-Z]{3,3}" to Currency?
  • in the name you added the description "Restriction for payment type SEPA is 70 characters" - would it not make sense to replace "payment type SEPA" with sepaindicator=true (or similar) because payment type does not exist in JSON spec?

Hi @zioerjenthomas,
as discussed bilaterally, i have adjusted the following:

  • Address for Payments changed to "PaymentPostalAddress"
  • Description of PaymentAddress changed to "The postal adress of a participant within the payment. Corresponds to the attribute PstlAdr in SPS/ISO-20022."
  • Description of Country changed to "The ISO country two-letter code. Corresponds to the attribute Ctry in SPS/ISO-20022."
  • Pattern added to Country as '^[A-Z]{2}$'

The following inputs will be taken up in a separate issue for adjustments in v6:

  • add pattern "[A-Z]{3,3}" to Currency
  • in the name you added the description "Restriction for payment type SEPA is 70 characters" - would it not make sense to replace "payment type SEPA" with sepaindicator=true (or similar) because payment type does not exist in JSON spec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjustments Implementation Guidelines SPS 2025
2 participants