Fix location for diagnostics generated from macros via swiftc #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The format of messages generated from macro errors/warnings is different than those generated normally. The parsing regex would capture the location for the related info diagnostic with a backtick. The location for the parent regex would be "#macro expansion" which when clicked would open an error window in a VS Code tab stating that the file "#macro expansion" could not be found. This patch tweaks two things: 1. Makes the regex for capturing the filepaths of warnings/errors account for leading trivia 2. If the path for a diagnostic is invalid, wait until we parse the related infromation and use the URI from there.
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
award999
approved these changes
Nov 28, 2024
plemarquand
force-pushed
the
diagnostics-from-macros
branch
2 times, most recently
from
be8683b to
4fd1b11
Compare
plemarquand
force-pushed
the
diagnostics-from-macros
branch
from
4fd1b11 to
9ae189a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format of messages generated from macro errors/warnings is different than those generated normally. The parsing regex would capture the location for the related info diagnostic with a backtick. The location for the parent regex would be "#macro expansion" which when clicked would open an error window in a VS Code tab stating that the file "#macro expansion" could not be found.
This patch tweaks two things:
Issue #1224