Add integration test for swift.runPluginTask command #1231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-weng
requested review from
adam-fowler,
0xTim and
award999
as code owners
michael-weng
force-pushed
the
plugin_command
branch
from
51d270c to
f404498
Compare
- Change runPluginTask to return the argument filter for better testability - Given SwiftPluginTaskProvider integration test already test the tasks, assert the command arguments are valid and return the right tasks for picking - Minor clean up like removing redudant suite clean up and switch to use constant enum Issue: swiftlang#1230
michael-weng
force-pushed
the
plugin_command
branch
from
1fe6189 to
02d654a
Compare
|
Superseded by #1256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1230