Reorganize LSP extensions #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbastien
requested review from
adam-fowler,
0xTim and
award999
as code owners
award999
reviewed
Nov 27, 2024
| /** | ||
| * Used to create a {@link LanguageClient} for use in VS Code. | ||
| * | ||
| * This is primarily used to make unit testing easier so that we don't have to |
award999
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Organize our LSP extensions in the same way that vscode-languageclient does: by using a namespace that includes all of the relevant information related to the Request/Notification. This allows us to use our LSP extensions in the same type-safe manor as we do with built-ins.