-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Windows GH actions job #1195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
award999
force-pushed
the
win-gh-actions
branch
2 times, most recently
from
November 4, 2024 20:09
cf61bf1
to
a64cba3
Compare
plemarquand
reviewed
Nov 4, 2024
award999
force-pushed
the
win-gh-actions
branch
from
November 6, 2024 16:34
acfdd24
to
7014f83
Compare
@swift-ci Please test |
award999
force-pushed
the
win-gh-actions
branch
8 times, most recently
from
November 7, 2024 15:54
6dc7960
to
ad86a3a
Compare
@swift-ci Please test |
1 similar comment
@swift-ci Please test |
award999
force-pushed
the
win-gh-actions
branch
8 times, most recently
from
November 8, 2024 19:51
1146056
to
8878469
Compare
plemarquand
force-pushed
the
win-gh-actions
branch
6 times, most recently
from
November 13, 2024 15:55
31971f9
to
2077b85
Compare
…tion in extension setup
plemarquand
force-pushed
the
win-gh-actions
branch
from
December 3, 2024 15:51
c5ba0cf
to
72fd9cb
Compare
plemarquand
force-pushed
the
win-gh-actions
branch
from
December 3, 2024 18:41
ad8c32e
to
ef8544d
Compare
matthewbastien
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have a few minor things I'd like fixed, but I'm fine with fixing them in a future PR since this gets Windows CI up and running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot use the existing windows job setup because it launches a docker container which we cannot open a VS Code window in to run the tests as no tool like Xvfb exists for Windows
Fix up some tests that fail on windows (mostly related to path separator mismatches)