Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Windows GH actions job #1195

Merged
merged 57 commits into from
Dec 3, 2024
Merged

Conversation

award999
Copy link
Contributor

@award999 award999 commented Nov 4, 2024

We cannot use the existing windows job setup because it launches a docker container which we cannot open a VS Code window in to run the tests as no tool like Xvfb exists for Windows

Fix up some tests that fail on windows (mostly related to path separator mismatches)

@award999 award999 force-pushed the win-gh-actions branch 2 times, most recently from cf61bf1 to a64cba3 Compare November 4, 2024 20:09
@award999
Copy link
Contributor Author

award999 commented Nov 6, 2024

@swift-ci Please test

@award999 award999 force-pushed the win-gh-actions branch 8 times, most recently from 6dc7960 to ad86a3a Compare November 7, 2024 15:54
@award999
Copy link
Contributor Author

award999 commented Nov 7, 2024

@swift-ci Please test

1 similar comment
@award999
Copy link
Contributor Author

award999 commented Nov 7, 2024

@swift-ci Please test

@award999 award999 force-pushed the win-gh-actions branch 8 times, most recently from 1146056 to 8878469 Compare November 8, 2024 19:51
@plemarquand plemarquand force-pushed the win-gh-actions branch 6 times, most recently from 31971f9 to 2077b85 Compare November 13, 2024 15:55
@plemarquand plemarquand marked this pull request as ready for review December 3, 2024 19:08
Copy link
Member

@matthewbastien matthewbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a few minor things I'd like fixed, but I'm fine with fixing them in a future PR since this gets Windows CI up and running.

src/TestExplorer/TestRunner.ts Show resolved Hide resolved
src/commands/build.ts Outdated Show resolved Hide resolved
@plemarquand plemarquand merged commit 3c116a4 into swiftlang:main Dec 3, 2024
18 checks passed
@award999 award999 deleted the win-gh-actions branch January 8, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants