Add integration tests for build commands #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-weng
requested review from
adam-fowler,
0xTim and
award999
as code owners
award999
requested changes
Oct 31, 2024
michael-weng
force-pushed
the
build_cmd_itest
branch
2 times, most recently
from
48338b6 to
62f0931
Compare
- Validate the workflow of user calling the Swift: Run Build/Clean Build/Debug Build commands. - Ensure Swift: Run Build will not get blocked by pre-set breakpoint. - Ensure Swift: Clean Build will result in a cleaned up .build folder. - Ensure Swift: Debug Build will stop on a breakpoint and resume. Issue: swiftlang#1184
- Added comments for clarification - Added utilities to listen for dap message, this is useful for test synchronization. Code takes inspiration from swiftlang#1126
- Minor cosmetic change to utilies/commands.ts
michael-weng
force-pushed
the
build_cmd_itest
branch
from
62f0931 to
240dc39
Compare
award999
reviewed
Nov 5, 2024
| const result = vscode.commands.executeCommand(Commands.DEBUG); | ||
| expect(result).to.eventually.be.true; | ||
|
|
||
| await bpPromise.then(() => continueSession()); |
There was a problem hiding this comment.
if we're hitting breakpoints, crossing into smoke level, let's create a smoke suite and put that there
There was a problem hiding this comment.
I thought that's what @slow do right now?
There was a problem hiding this comment.
still should split into separate suite. Is it actually slow or just trying to keep out of CI build?
There was a problem hiding this comment.
What are we trying to achieve to split this into a separate suite? Is it for dependency management?
Given the test run fast and this is a command that should probably always work, I am not sure if we want keep this out of CI.
There was a problem hiding this comment.
will leave this for until long term approach is decided
returned, causing restore of setting being not awaitable - Make makeDebugConfigurations to be awaitable - Change launch to also update the key for ASLR disable settings - Make the test properly set up and reset the settings that update the launch config
award999
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1184