Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] GitHub Actions support #1159

Merged
merged 9 commits into from
Nov 4, 2024

Conversation

shahmishal
Copy link
Member

No description provided.

@shahmishal shahmishal force-pushed the github-actions-support branch 2 times, most recently from 56f610e to 9962564 Compare October 25, 2024 05:57
@shahmishal
Copy link
Member Author

shahmishal commented Oct 25, 2024

Need to be resolved in the future:
#1161
#1162

@award999
Copy link
Contributor

Thanks so much @shahmishal. Looking at the output test fail but step succeeds. If the script provided to linux_build_command: ./docker/test.sh returns a non-zero exit code, is it expected to fail? If so I'll run down why the exit code is wrong

@plemarquand
Copy link
Contributor

@shahmishal Do you have any guidance on how to run a GH action at desk? Ideally the tests for just one Swift version.

@shahmishal
Copy link
Member Author

@shahmishal Do you have any guidance on how to run a GH action at desk? Ideally the tests for just one Swift version.

To reproduce the steps locally: https://github.com/swiftlang/github-workflows?tab=readme-ov-file#running-workflows-locally

@plemarquand
Copy link
Contributor

Thanks, I was able to test a single swift configuration locally with act using the matrix flag: act -j tests --matrix swift_version:5.8

@plemarquand plemarquand force-pushed the github-actions-support branch from 42e01fd to afa89d0 Compare October 28, 2024 12:34
plemarquand added a commit to plemarquand/vscode-swift that referenced this pull request Nov 1, 2024
This allows us to turn off the licence check GitHub Action temporarily
until we can merge swiftlang#1176, which unblocks swiftlang#1159, allowing us to start
using the GitHub Actions CI flow.
plemarquand added a commit that referenced this pull request Nov 1, 2024
This allows us to turn off the licence check GitHub Action temporarily
until we can merge #1176, which unblocks #1159, allowing us to start
using the GitHub Actions CI flow.
@plemarquand plemarquand force-pushed the github-actions-support branch from 2fd0efc to a773fc6 Compare November 1, 2024 14:44
@plemarquand plemarquand force-pushed the github-actions-support branch from 35f7e16 to b98891e Compare November 1, 2024 15:26
@plemarquand plemarquand force-pushed the github-actions-support branch from 9b982f1 to 4825915 Compare November 1, 2024 19:28
@plemarquand plemarquand merged commit a4d7b0c into swiftlang:main Nov 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants