Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.1] Support background indexing when cross-compiling #1939

Merged
merged 2 commits into from
Jan 21, 2025
Merged

[6.1] Support background indexing when cross-compiling #1939

merged 2 commits into from
Jan 21, 2025
+84 −0

Conversation

kabiroberai
Copy link
Contributor

@kabiroberai kabiroberai commented Jan 21, 2025 •
edited by ahoppen
Loading

  • Explanation: Previously, if you selected a Swift SDK via the swiftPM.swiftSDK configuration option, background indexing would fail because the swift build --experimental-prepare-for-indexing invocation did not pass along the --swift-sdk argument.
  • Scope: Background indexing when swiftPM.swiftSDK is specified in the SourceKit-LSP configuration file
  • Issue: n/a
  • Original PR: Support background indexing when cross-compiling #1923
  • Risk: Low, only passes a few options through
  • Testing: Added a test case
  • Reviewer: @ahoppen

@kabiroberai
Forward cross-compilation args when indexing
d6ae675
@kabiroberai
Add cross-compilation regression test
af08a48 
Feedback

More cleanup

Allow skipping canSwiftPMCompileForIOS on CI

Format
@kabiroberai kabiroberai requested a review from ahoppen as a code owner January 21, 2025 17:04
@kabiroberai kabiroberai mentioned this pull request Jan 21, 2025
Merged
@ahoppen ahoppen requested a review from bnbarham January 21, 2025 17:40
@ahoppen
Copy link
Member

ahoppen commented Jan 21, 2025

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge January 21, 2025 19:53
@ahoppen ahoppen merged commit 2e2ef46 into swiftlang:release/6.1 Jan 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kabiroberai @ahoppen @bnbarham