Support opening documents within the same workspace with sourcekitd/clangd from different toolchains #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
approved these changes
Jan 24, 2025
| /// Otherwise, return `nil`. | ||
| package func toolchain(withCompiler compiler: URL) -> Toolchain? { | ||
| for toolchain in toolchains { | ||
| if [toolchain.clang, toolchain.swift, toolchain.swiftc].contains(compiler) { |
There was a problem hiding this comment.
Depending on how often this is called, we could instead store a mapping of compiler URL -> toolchain in the registry?
There was a problem hiding this comment.
Good call. Turns out we can do a bit more clean-up in the ToolchainRegistry initializer. I’ve opened #1953 for that.
|
@swift-ci Please test |
…langd from different toolchains rdar://142909783
ahoppen
force-pushed
the
multi-toolchain-support
branch
from
b109ba4 to
98b1294
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://142909783