[C++ Safe Buffers][BoundsSafety] Fix that some interop diagnostics cannot be suppressed by unsafe_buffer_usage_begin/end #10198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nnot be suppressed by __unsafe_buffer_usage_begin/end The interop diagnostics emitted in Sema cannot be suppressed by `#pragma clang unsafe_buffer_usage begin/end`. This is because the opt-out regions marked by those pragmas are stored in Preprocessor not DiagnosticsEngine. We need query both the Preprocessor and DiagnosticsEngine to confirm if C++ Safe Buffers is enabled at a location. This commit fixes this problem. (rdar://146438364)
|
CC @dtarditi |
patrykstefanski
approved these changes
Mar 7, 2025
|
@swift-ci test |
hnrklssn
reviewed
Mar 7, 2025
| Loc.isInvalid() || !getPreprocessor().isSafeBufferOptOut(SourceMgr, Loc); | ||
| return LangOpts.CPlusPlus && LangOpts.isBoundsSafetyAttributeOnlyMode() && | ||
| NotSupressedByPragmas && | ||
| !Diags.isIgnored(diag::warn_unsafe_buffer_operation, Loc); |
There was a problem hiding this comment.
Why do we need to check whether the diagnostic is ignored? If it's ignored it wouldn't be emitted anyways, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interop diagnostics emitted in Sema cannot be suppressed by
#pragma clang unsafe_buffer_usage begin/end. This is because the opt-out regions marked by those pragmas are stored in Preprocessor not DiagnosticsEngine. We need query both the Preprocessor and DiagnosticsEngine to confirm if C++ Safe Buffers is enabled at a location. This commit fixes this problem.(rdar://146438364)