Cherrypick for 143986251 & 145705060 #10156
Conversation
…ts to counted_by parameters (swiftlang#9971) Add support of - overloaded subscript operator of hardened view/containers, and - calls to const member functions of 0 arguments Now it can match patterns like: ``` std::span<char> D, S; std::array<std::span<char>, 10> A; memcpy(D.first(S.size()).data(), S.data(), S.size()); memcpy(D.first(A[x].size()).data(), A[x].data(), A[x].size()); ``` (rdar://143986251)
…an cause infinite loops
The interop analysis substitutes formal parameters to arguments in AST
visiting. Conceptually, the substitution should be done exactly once.
But the previous implementation never checked if the substitution has
happened. In cases where the argument contains DREs referring to the
Decl of the corresponding formal parameter, the analysis enters an
infinite loop. A typical example is the following.
```
void f(int * __counted_by(n) p, size_t n) {
f(p, n);
}
```
This commit fixes the issue.
(rdar://145705060)
(cherry picked from commit 31f72f7)
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
FYI, it would be nice to use more descriptive titles for the pull requests. Many people active in this repository cannot decode radar numbers. |
|
Also, I think this was not run test for LLVM |
Thanks for the heads-up. I have a fix here: #10175 |
Original PRs:
#10129
#9971