Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Swift 6 #341

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Require Swift 6 #341

merged 5 commits into from
Aug 28, 2024

Conversation

aryan-25
Copy link
Contributor

Motivation:

  • This PR paves the way to land the new API discussed in v2 API Proposal Document #339.
  • AWS Lambda Runtime v2 will require Swift 6 as it will enforce full Sendability checking.
  • For us to land the PRs that work towards our new API, we need to require Swift 6.

Modifications:

  • Change swift-tools-version from 5.9 to 6.0 in Package.swift.
  • Use Swift 5 Language Mode for all targets.
  • Modify Plugin.swift to compile error-free with Swift 6.

Result:

First step towards adopting Swift 6.

@fabianfett
Copy link
Member

@swift-server-bot add to whitelist

@fabianfett fabianfett requested a review from sebsto August 23, 2024 11:56
Copy link
Contributor

@sebsto sebsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabianfett
Copy link
Member

Let's land #340 and then rebase on top of it.

Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Let's get CI in order

@fabianfett
Copy link
Member

API breakage and doc check fail because of 5.10 requirement. Merging to unblock further work for now. Will enforce at a later point in time again.

@fabianfett fabianfett merged commit f329874 into swift-server:main Aug 28, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants