Fix bug that resulted in empty linker flags on MacOS [AP-3221] #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `9b5d663`, a bug was introduced that resulted in empty linker flags on MacOS. In Starlark, `[a] + [b] if c else []` results in `[]`, if `c` is False. To just make `[b]` conditional, parenthesis must be used: `[a] + ([b] if c else [])`.
sbmueller
force-pushed
the
smuller/AP-3221-fix-linker-flags
branch
from
1a9bb41 to
aa9019f
Compare
sbmueller
changed the title
IsakTjernberg
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
9b5d663, a bug was introduced that resulted in empty linker flagson MacOS. In Starlark,
[a] + [b] if c else []results in[], ifcis False. Tojust make
[b]conditional, parenthesis must be used:[a] + ([b] if c else []).