Remove unnecessary condition in _safe_flags function #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reimerix
force-pushed
the
reimerix/patch-clang-tidy
branch
from
0685629 to
1526d46
Compare
jungleraptor
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
I think we probably added this to work around the fact that bazel doesn't distinguish between options for c++ or c files, so we were running into issues where it would pass -std=c++14 (or similiar), when compiling a c file, and that would error because we're building with -Werror (warning that the option is not recognized for c files).
But we figured out how to work around that quite a while ago so we probably just forgot to remove this hack.
Assuming this doesn't break anything I think we should definitely take this fix.
pcrumley
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cover the following topics in the description:
Jira Reference
Link to a Jira ticket: