Skip to content

Commit

Permalink
Fix sonarcloud analysis warning, restrict python version to avoid dis…
Browse files Browse the repository at this point in the history
…tutils issues (#600)

## Rationale

Sonarcloud emits the following warning:

<img width="1687" alt="image"
src="https://github.com/swift-nav/libsettings/assets/12671231/34a72119-1508-4337-a040-ca298a00bf5d">


Issue has already been fixed on
orion/orion-engine/skylark-fault-injector by updating sonar-scanner's
version to `5.0.1.3006`

Note: 

## Testing

Warning does not appear anymore for this PR's analysis:
TODO
  • Loading branch information
armallen authored Nov 13, 2023
1 parent 6c336e9 commit 75875de
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 16 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/cmake.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
name: CMake
'on':
"on":
push:
branches:
- 'master'
- "master"
tags:
- 'v[0-9]+.[0-9]+.[0-9]+*'
- "v[0-9]+.[0-9]+.[0-9]+*"
pull_request: ~
jobs:
# Regular C build with two compilers, using the environment:
Expand Down Expand Up @@ -35,7 +35,7 @@ jobs:
linters:
strategy:
matrix:
preset: [ cppcheck, clang-tidy ]
preset: [cppcheck, clang-tidy]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -53,7 +53,7 @@ jobs:
matrix:
preset:
- clang-sanitize-address
# - clang-sanitize-memory
# - clang-sanitize-memory
- clang-sanitize-undefined
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:
coverage:
runs-on: ubuntu-latest
env:
SONAR_SCANNER_VERSION: 4.7.0.2747
SONAR_SCANNER_VERSION: 5.0.1.3006
SONAR_SERVER_URL: "https://sonarcloud.io"
SONAR_ORG: swift-nav
SONAR_PROJECT_KEY: swift-nav_libsettings
Expand All @@ -97,7 +97,7 @@ jobs:
- name: Set up JDK
uses: actions/setup-java@v3
with:
distribution: 'temurin'
distribution: "temurin"
java-version: 11
- name: Set up Python for gcovr
uses: actions/setup-python@v2
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/wheels.yaml
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
name: Wheels
'on':
"on":
pull_request: ~
push:
branches:
- 'master'
- "master"
tags:
- '[0-9]+.[0-9]+.[0-9]+*'
- 'v[0-9]+.[0-9]+.[0-9]+*'
- "[0-9]+.[0-9]+.[0-9]+*"
- "v[0-9]+.[0-9]+.[0-9]+*"
jobs:
build_wheels:
name: Build wheels on ${{ matrix.os.name }}
runs-on: ${{ matrix.os.name }}
strategy:
matrix:
os:
- {name: "ubuntu-20.04", needs_qemu: true}
- {name: "windows-2019", needs_qemu: false}
- {name: "macOS-11", needs_qemu: false}
- { name: "ubuntu-20.04", needs_qemu: true }
- { name: "windows-2019", needs_qemu: false }
- { name: "macOS-11", needs_qemu: false }
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -26,7 +26,7 @@ jobs:
- uses: docker/setup-qemu-action@v2
if: ${{ matrix.os.needs_qemu }}
- name: Install cibuildwheel
run: python -m pip install cibuildwheel==2.13.0 cython
run: python -m pip install setuptools cibuildwheel==2.13.0 cython
- name: Build wheels
run: |
cythonize python/libsettings.pyx
Expand All @@ -48,7 +48,7 @@ jobs:
submodules: recursive
- uses: actions/setup-python@v3
- name: Install build
run: python -m pip install build cython
run: python -m pip install setuptools build cython
- name: Build wheels
run: |
cythonize python/libsettings.pyx
Expand Down

0 comments on commit 75875de

Please sign in to comment.