-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOTE-6][IOTE-326] Add weeks behavior flag to MSG_GNSS_TIME_OFFSET #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakalm
force-pushed
the
jakob/iote-6/amazon-timestamp
branch
from
March 15, 2024 10:27
eec10de
to
1a604cd
Compare
jakalm
changed the title
[IOTE-6][IOTE-325] Status flags for MSG_GNSS_TIME_OFFSET is no longer reserved
[IOTE-6][IOTE-326] Add local timestamp week rollover flag
Mar 15, 2024
jakalm
force-pushed
the
jakob/iote-6/amazon-timestamp
branch
8 times, most recently
from
March 16, 2024 10:07
6118f99
to
0af9579
Compare
jakalm
force-pushed
the
jakob/iote-6/amazon-timestamp
branch
from
March 16, 2024 10:18
0af9579
to
5d2e906
Compare
jakalm
changed the title
[IOTE-6][IOTE-326] Add local timestamp week rollover flag
[IOTE-6][IOTE-326] Add weeks behavior flag to MSG_GNSS_TIME_OFFSET
Mar 16, 2024
jakalm
requested review from
jungleraptor,
a team,
notoriaga and
pcrumley
as code owners
March 16, 2024 12:39
reimerix
approved these changes
Mar 18, 2024
sokhealy
reviewed
Mar 18, 2024
sokhealy
reviewed
Mar 18, 2024
sokhealy
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, apologies for my confusion.
jungleraptor
approved these changes
Mar 18, 2024
ljbade
approved these changes
Mar 25, 2024
Quality Gate passed for 'libsbp-c'Issues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@swift-nav/devinfra
Adding a new flag to the reserved
flags
field in theMSG_GNSS_TIME_OFFSET
message to flag if the timestamp is affected by local timestamp rollover or not. For more information, see https://swift-nav.atlassian.net/wiki/spaces/~622a65696a4c4c0070b2567a/pages/3060662918/Amazon+INS+timestamp+issue+way+forward#Conclusion-and-decision.API compatibility
Does this change introduce a API compatibility risk?
No, this has been a reserved field so should not be incompatible with current implementations of the protocol.
API compatibility plan
JIRA Reference
https://swift-nav.atlassian.net/browse/IOTE-325