Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: check time source for MsgGpsTime #1375

Merged
merged 1 commit into from
Nov 13, 2023
Merged

rust: check time source for MsgGpsTime #1375

merged 1 commit into from
Nov 13, 2023

Conversation

notoriaga
Copy link
Contributor

Description

@swift-nav/devinfra

API compatibility

Does this change introduce a API compatibility risk?

API compatibility plan

If the above is "Yes", please detail the compatibility (or migration) plan:

JIRA Reference

https://swift-nav.atlassian.net/browse/BOARD-XXXX

pcrumley
pcrumley approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@pcrumley pcrumley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable if we want to implement a fix to: #1363

I had a small fix to turn for terseness but I don't mind it as written. (edit my suggestion was not a good one)

@notoriaga notoriaga marked this pull request as ready for review November 13, 2023 18:24
@notoriaga notoriaga requested review from jungleraptor and a team as code owners November 13, 2023 18:24
@notoriaga notoriaga merged commit 12f7c44 into master Nov 13, 2023
14 checks passed
@notoriaga notoriaga deleted the steve/gps_time branch November 13, 2023 18:48
@pcrumley pcrumley mentioned this pull request Nov 13, 2023
Closed
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Nov 13, 2023
Closed
@notoriaga notoriaga mentioned this pull request Nov 14, 2023
Merged
notoriaga added a commit that referenced this pull request Nov 14, 2023
@notoriaga
rust: check more messages for time validity (#1376)
9b9dcd1 
# Description

Same as #1375 but accounts for
the other 3 time messages and msg_odometry

@swift-nav/devinfra

<!-- Changes proposed in this PR -->

# API compatibility

Does this change introduce a API compatibility risk?

<!-- Provide a short explanation why or why not -->

## API compatibility plan

If the above is "Yes", please detail the compatibility (or migration)
plan:

<!-- Provide a short explanation plan here -->

# JIRA Reference

https://swift-nav.atlassian.net/browse/BOARD-XXXX
@swiftnav-svc-jenkins swiftnav-svc-jenkins mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrumley pcrumley pcrumley approved these changes

@jungleraptor jungleraptor Awaiting requested review from jungleraptor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notoriaga @pcrumley