Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ad-hoc DiagonalWrapper with built-in Eigen approach #423

Merged
merged 1 commit into from
May 24, 2023
Merged

Replace ad-hoc DiagonalWrapper with built-in Eigen approach #423

merged 1 commit into from
May 24, 2023
+2 −7

Conversation

peddie
Copy link
Contributor

@peddie peddie commented May 18, 2023

As far as I can tell, this is mathematically and operationally equivalent, but using Eigen's built-in functionality for producing a diagonal matrix expression from a 1-d array solves issue #419.

@peddie
Replace ad-hoc DiagonalWrapper with built-in Eigen approach
8faa450 
As far as I can tell, this is mathematically and operationally
equivalent, but using Eigen's built-in functionality for producing a
diagonal matrix expression from a 1-d array solves issue
#419.
john-michaelburke
john-michaelburke approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@john-michaelburke john-michaelburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good hunting!

@peddie peddie requested a review from akleeman May 18, 2023 04:28
@peddie
Copy link
Contributor Author

peddie commented May 18, 2023

When building with g++, I still see the warning Intel MKL ERROR: Parameter 6 was incorrect on entry to DGEMV . I'm not clear whether this is a problem for us in practice if the results for the test are still computed correctly.

akleeman
akleeman approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@akleeman akleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@peddie peddie merged commit 7926d5e into master May 24, 2023
@peddie peddie deleted the peddie/safer-transformed-diagonal branch May 24, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akleeman akleeman

@john-michaelburke john-michaelburke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peddie @akleeman @john-michaelburke