Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bazel --config=mkl #422

Merged
merged 1 commit into from
May 31, 2023
Merged

Add bazel --config=mkl #422

merged 1 commit into from
May 31, 2023
+26 −2

Conversation

john-michaelburke
Copy link
Contributor

@john-michaelburke john-michaelburke commented May 18, 2023 •
edited
Loading

Implements

  • Uprevs rules_swiftnav version.
  • Adds MKL config which triggers Eigen linkage with intel mkl for linux.

Testing

  • The unittests fail with this configuration but we can address them in a future PR.

@john-michaelburke john-michaelburke requested a review from peddie May 18, 2023 01:49
@peddie
Copy link
Contributor

peddie commented May 18, 2023

I don't think the failure is due to problems with async calculation. I would look into #419 since the failure occurred in the same unit test.

akleeman
akleeman approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@akleeman akleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@john-michaelburke john-michaelburke merged commit 6b49f69 into master May 31, 2023
@john-michaelburke john-michaelburke deleted the john-michaelburke/add-bazel-mkl branch May 31, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akleeman akleeman

@peddie peddie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@john-michaelburke @peddie @akleeman