fix(build): Fix webpack externals config to use correct package names…

… in CJS environments, closes #9
sweetalert2 · Mar 7, 2018 · 1063416 · 1063416
1 parent 29afef7
commit 1063416
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -68,7 +68,7 @@
     "react-dom": "^16.2.0",
     "semantic-release": "^15.0.0",
     "sweetalert2": "^7.15.1",
-    "webpack": "^4.1.0",
+    "webpack": "^4.1.1",
     "webpack-serve": "^0.1.5"
   },
   "eslintConfig": {

diff --git a/webpack.config.dist.js b/webpack.config.dist.js
@@ -1,15 +1,28 @@
 /* eslint-env node */
 const path = require('path')
 
+function expandExternalsConfig(compactConfig) {
+  const expandedConfig = {}
+  for (const packageName of Object.keys(compactConfig)) {
+    expandedConfig[packageName] = {
+      commonjs: packageName,
+      commonjs2: packageName,
+      amd: packageName,
+      root: compactConfig[packageName],
+    }
+  }
+  return expandedConfig
+}
+
 module.exports = {
   mode: 'production',
   devtool: 'source-map',
   entry: [require.resolve('./src/main')],
-  externals: {
+  externals: expandExternalsConfig({
     react: 'React',
     'react-dom': 'ReactDOM',
     sweetalert2: 'swal',
-  },
+  }),
   output: {
     library: 'sweetalert2ReactContent',
     libraryTarget: 'umd',