Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json for Angular 18 support #265

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

eavab
Copy link
Contributor

@eavab eavab commented Jun 26, 2024

Updated peer dependency to support Angular 18

fixes #263

Summary by CodeRabbit

  • New Features
    • Added support for Angular version 18.0.0.

Updated peer dependency to support Angular 18
Copy link

coderabbitai bot commented Jun 26, 2024

Walkthrough

The changes to ngx-sweetalert2 in the package.json file primarily introduce support for Angular version 18.0.0 by updating the version ranges for peer dependencies @angular/common and @angular/core. This ensures compatibility with the latest Angular framework, addressing users' needs to upgrade to Angular 18 seamlessly.

Changes

File Change Summary
projects/ngx-sweetalert2/... Updated @angular/common and @angular/core version range to ^18.0.0

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Support for Angular 18 (#263)

Poem

A new dawn rises with Angular's might,
Version 18 leads us to new heights.
Sweet alerts now fully in line,
With core and common, our code's divine.
Let's celebrate this small release,
For seamless upgrades and coding peace. 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@eavab eavab changed the title Update package.json Update package.json for Angular 18 support Jun 26, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 46a0851 and b22bc36.

Files selected for processing (1)
  • projects/ngx-sweetalert2/package.json (1 hunks)
Additional comments not posted (2)
projects/ngx-sweetalert2/package.json (2)

12-12: Updated peer dependency for @angular/common approved.

The addition of ^18.0.0 ensures compatibility with Angular 18 while maintaining support for previous versions.


13-13: Updated peer dependency for @angular/core approved.

The inclusion of ^18.0.0 aligns with the project's goal to support Angular 18, ensuring the library remains compatible with the latest Angular version.

@limonte
Copy link
Member

limonte commented Jun 26, 2024

thanks @eavab

@limonte limonte merged commit 4a349dd into sweetalert2:main Jun 26, 2024
1 check passed
@limonte
Copy link
Member

limonte commented Jun 26, 2024

🎉 This PR is included in version 12.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Angular 18
2 participants