Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed login, signup page and added scroll to top button #153

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

devarsheecodess
Copy link
Contributor

What does this PR do?

In this PR, i have fixed the issues in login and signup page, also i have added a scroll to top button to the website

Fixes #88 and #89

Recording.2024-10-13.153138.mp4

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Check login and signup page
  • check the mainpage of website where i have added scroll on top button

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented Oct 13, 2024

@devarsheecodess is attempting to deploy a commit to the Piyush's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @devarsheecodess for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@devarsheecodess
Copy link
Contributor Author

@swarooppatilx i have fixed #88 and #89 , both had level1 labels so for this PR you have to add level2 label along with gssoc-ext and hacktoberfest-accepted

Copy link
Owner

@swarooppatilx swarooppatilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@swarooppatilx swarooppatilx added gssoc-ext GirlScript Summer of Code Extended 2024 level1 GirlScript Summer of Code Level 1 Issue hacktoberfest-accepted Hacktoberfest labels Oct 13, 2024
@swarooppatilx swarooppatilx merged commit b9a0357 into swarooppatilx:main Oct 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext GirlScript Summer of Code Extended 2024 hacktoberfest-accepted Hacktoberfest level1 GirlScript Summer of Code Level 1 Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scroll on top button
2 participants