-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add multi-arch docker build for linux/arm64/v8 #11772
Conversation
@frantuma @HugoMario What do you think about this change? Could we release this with next version so swagger-codegen would be supported on M1 machines. |
This would be a very welcome change to our CI pipelines 👍 |
Do you know when the first image will be available? |
For everyone who is waiting for this pull request in the meanwhile you can use this. https://hub.docker.com/r/mitjaziv/swagger-codegen-cli |
1b608f8
to
4b197ea
Compare
4b197ea
to
eb42cbb
Compare
Can one of the organization members take a look at this PR and merge it? |
Similar response to @Dynehart above. Could someone look into updating this PR and merging? Thanks! |
eb42cbb
to
0d00658
Compare
Bump, again. Could a maintainer take a look into this PR? |
@mitjaziv I'm not a maintainer but I would recommend to make only the change that is required. Replace They are probably too busy to understand the rest of the change. Even though I agree it should be done. They probably don't use |
bump @char0n @frantuma @gracekarina @HugoMario @ponelat @HugoMario please, we really need this |
Bump |
0d00658
to
030cbe7
Compare
Hi folks, sorry for all the waiting. Will take a look into this. Thank you for your patience. |
030cbe7
to
276d487
Compare
I guess this is really old PR, and a lot was changed since it was opened, so I would need to re-investigate what needs to be changed, to fix pipelines. |
Thanks all for your patience, this has been replaced by the following changes adding multi-platform images builds: #12290, #12291, #12292, #12293, #12294 similar changes are being applied to 3.0.0 branch |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.3.0.0
branch for changes related to OpenAPI spec 3.0. Default:master
.Description of the PR
This PR adds multi-arch build with
docker buildx
to add support for Apple M1 machines.Closes #11650