Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multi-arch docker build for linux/arm64/v8 #11772

Closed
wants to merge 1 commit into from

Conversation

mitjaziv
Copy link

@mitjaziv mitjaziv commented Apr 22, 2022

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR adds multi-arch build with docker buildx to add support for Apple M1 machines.

Closes #11650

@mitjaziv
Copy link
Author

@frantuma @HugoMario What do you think about this change? Could we release this with next version so swagger-codegen would be supported on M1 machines.

@joaosa
Copy link

joaosa commented May 19, 2022

This would be a very welcome change to our CI pipelines 👍

@fellnerse
Copy link

Do you know when the first image will be available?

@mitjaziv
Copy link
Author

For everyone who is waiting for this pull request in the meanwhile you can use this.

https://hub.docker.com/r/mitjaziv/swagger-codegen-cli
https://github.com/mitjaziv/swagger-codegen

@Dynehart
Copy link

Can one of the organization members take a look at this PR and merge it?
@char0n @frantuma @gracekarina @HugoMario @ponelat

@joshmurrayeu
Copy link

Similar response to @Dynehart above. Could someone look into updating this PR and merging? Thanks!

@joshmurrayeu
Copy link

Bump, again. Could a maintainer take a look into this PR?

@char0n @frantuma @gracekarina @HugoMario @ponelat

@andresvia
Copy link

@mitjaziv I'm not a maintainer but I would recommend to make only the change that is required.

Replace docker build with docker buildx build --platform linux/arm64/v8,linux/amd64

They are probably too busy to understand the rest of the change. Even though I agree it should be done. They probably don't use shellcheck 🤷

@wandergeek
Copy link

bump @char0n @frantuma @gracekarina @HugoMario @ponelat @HugoMario please, we really need this

@repositarian
Copy link

Bump
Somebody please check & merge this PR. We really need this
@char0n @frantuma @gracekarina @HugoMario @ponelat @HugoMario

@ponelat
Copy link
Member

ponelat commented Nov 15, 2023

Hi folks, sorry for all the waiting. Will take a look into this. Thank you for your patience.

@mitjaziv
Copy link
Author

Hi folks, sorry for all the waiting. Will take a look into this. Thank you for your patience.

I guess this is really old PR, and a lot was changed since it was opened, so I would need to re-investigate what needs to be changed, to fix pipelines.

@frantuma
Copy link
Member

Thanks all for your patience, this has been replaced by the following changes adding multi-platform images builds:

#12290, #12291, #12292, #12293, #12294

similar changes are being applied to 3.0.0 branch

@frantuma frantuma closed this Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image fails on Apple silicone / M1
10 participants