Skip to content
This repository has been archived by the owner on Dec 9, 2021. It is now read-only.

User authentication using OAuth2 #211

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

se-bastiaan
Copy link
Contributor

@se-bastiaan se-bastiaan commented Oct 30, 2020

Closes #141

Summary

This switches our authentication method to using OAuth instead of the previously used "proprietary" token authentication. It also completely rewrites how network requests are executed.

How to test

Steps to test the changes you made:

  1. Login using your local instance
  1. Check every place where we do network requests
  2. All works!
  3. Now revoke your access token here: https://thalia.nu/admin/oauth2_provider/accesstoken/
  4. The app should now request a new access token using the refresh token
  5. All still works!

Todo

  • Fix tests
  • Add documentation to getting started
  • Fix CI builds

@se-bastiaan se-bastiaan added the feature Issues regarding a complete new feature label Oct 30, 2020
@se-bastiaan se-bastiaan changed the title OAuth login User authentication using OAuth2 Oct 30, 2020
@github-actions github-actions bot added the chore Something that is not a bug or a feature label Oct 30, 2020
@se-bastiaan se-bastiaan marked this pull request as ready for review November 12, 2020 21:02
Copy link
Contributor Author

@se-bastiaan se-bastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs GitHub Actions still

@KiOui
Copy link
Contributor

KiOui commented Nov 24, 2020

Is this one ready for a review? Also for the concrexit side of things?

@se-bastiaan
Copy link
Contributor Author

Yep

@se-bastiaan
Copy link
Contributor Author

But maybe it would be nice if I add the github actions properly and then you can just download the IPA

@se-bastiaan se-bastiaan self-assigned this Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Something that is not a bug or a feature feature Issues regarding a complete new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication using OAuth2
2 participants