This repository has been archived by the owner on Dec 9, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
User authentication using OAuth2 #211
Open
se-bastiaan
wants to merge
7
commits into
master
Choose a base branch
from
chore/server-url
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
se-bastiaan
force-pushed
the
chore/server-url
branch
from
November 12, 2020 20:30
1f783d5
to
464e17b
Compare
se-bastiaan
force-pushed
the
chore/server-url
branch
from
November 12, 2020 20:58
464e17b
to
6f6b09f
Compare
se-bastiaan
force-pushed
the
chore/server-url
branch
from
November 12, 2020 21:02
1233dc4
to
cc066ec
Compare
se-bastiaan
commented
Nov 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs GitHub Actions still
Is this one ready for a review? Also for the concrexit side of things? |
Yep |
But maybe it would be nice if I add the github actions properly and then you can just download the IPA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #141
Summary
This switches our authentication method to using OAuth instead of the previously used "proprietary" token authentication. It also completely rewrites how network requests are executed.
How to test
Steps to test the changes you made:
https://thalia.nu/admin/oauth2_provider/application/
https://staging.thalia.nu/admin/oauth2_provider/application/
Todo