Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added instagram logo #386

Merged

Conversation

SamStaijen
Copy link
Member

Added the instagram logo to the footer. Ideally I would pass all the external url's through 'doorgeefluik' (reduces possible search work would there be a url change on an external domain), but I beleave putting data in the 'doorgeefluik' database can be done as IT Crowd only, as there has not been a single commit on an active branch in 'doorgeefluik' the past 2 years. For now it is a instagram.com url, which is fine i guess

@SamStaijen SamStaijen self-assigned this Sep 23, 2024
@SamStaijen SamStaijen linked an issue Sep 23, 2024 that may be closed by this pull request
Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the code changes, but doorgeefluik would be better. I suggest we include the link in this PR, tomorrow

@SamStaijen
Copy link
Member Author

A board member currently has the URL's on his to-do; if all goes well I should get a follow-up as soon as they exist; i suggest we keep this PR open untill then

Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much wow

@SamStaijen SamStaijen merged commit 1508a7c into development Sep 24, 2024
2 checks passed
@SamStaijen SamStaijen deleted the 381-link-to-instagram-at-the-bottom-of-the-website branch September 24, 2024 18:05
stickyPiston pushed a commit that referenced this pull request Oct 9, 2024
* added instagram logo
* added doorgeefluik url's
stickyPiston pushed a commit that referenced this pull request Oct 9, 2024
* added instagram logo
* added doorgeefluik url's
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to instagram at the bottom of the website
3 participants