fix: image size based on parent #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to test it, but otherwise looks good! |
SilasPeters
approved these changes
Sep 18, 2024
TobiasDeBruijn
added a commit
that referenced
this pull request
Sep 23, 2024
* New workflow for adding newly opened issues to the CommITCrowd project
Perhaps the title says it all. This is a really simple workflow, and it's open for any changes or adjustments
* feat: Hide phone number if not filled in in Contentful
* Add introduction information to the website (#376)
* make default image with based on size of parent (#383)
* Update board color (#382)
* Automatically compute CYMK, RGB color from HEX (#385)
---------
Co-authored-by: Silas Peters <[email protected]>
Co-authored-by: Sem van Nieuwenhuizen <[email protected]>
Co-authored-by: sam32123 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when fetching an image from Contentfull, the image size is proportional to image size.
After this PR; default image witdth should be based on the size of the parent element