Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies and adjust cargo-deny config #1283

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Conversation

svix-jplatte
Copy link
Member

We're currently getting quite a few warnings from cargo-deny. Most are about duplicated dependencies, but some are more important to fix.

Also do some upgrades that weren't related to cargo-deny warnings.

@svix-jplatte svix-jplatte requested a review from a team as a code owner March 25, 2024 13:31
svix-gabriel
svix-gabriel previously approved these changes Mar 25, 2024
@svix-gabriel svix-gabriel dismissed their stale review March 25, 2024 14:02

Whoops. I missed the build failures

@svix-jplatte
Copy link
Member Author

Yeah, that's from jwt-simple. Currently assessing what to do about those, seems like the root issue is having both boringssl and openssl in the dependency tree: cloudflare/boring#197

0.17 contains multiple undocumented breaking changes, we can wait with
that upgrade.
The only unmaintained warning we had was for dotenv and an upcoming
version of cargo-deny will always error for unmaintained dependencies
(removing the configuration option) so might as well set it to deny now.
@svix-jplatte
Copy link
Member Author

jwt-simple upgrade backed out for now, and created an issue for it.

@svix-jplatte svix-jplatte requested a review from a team March 25, 2024 16:27
@svix-jplatte svix-jplatte merged commit 6e40bd5 into main Mar 25, 2024
6 checks passed
@svix-jplatte svix-jplatte deleted the jplatte/deps branch March 25, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants