Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop @typescript-eslint v4 support #464

Merged
merged 3 commits into from
Jan 21, 2024

Conversation

baseballyama
Copy link
Member

@baseballyama baseballyama commented Jan 21, 2024

We can not merge #399 if we continue to support @typescript-eslint v4.

@typescript-eslint v5 was released on October 12, 2021. (https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.0.0)
The number of v4 downloads is 1.9% of v6 downloads, but I believe that many of those are CIs from ecosystems such as ours.

image

image

We can merge #399 after merge this PR.

Copy link

changeset-bot bot commented Jan 21, 2024

🦋 Changeset detected

Latest commit: 2beb5cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Jan 21, 2024

Pull Request Test Coverage Report for Build 7598589705

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.454%

Totals Coverage Status
Change from base Build 7511062010: 0.0%
Covered Lines: 2490
Relevant Lines: 2633

💛 - Coveralls

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@ota-meshi ota-meshi merged commit d531e4e into main Jan 21, 2024
13 checks passed
@ota-meshi ota-meshi deleted the breaking/drop-@typescript-eslint-v4 branch January 21, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants