-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change it to use modern AST, if svelte v5 is installed #437
Conversation
🦋 Changeset detectedLatest commit: 2eea457 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 8127822619Details
💛 - Coveralls |
src/parser/compat.ts
Outdated
export function getOptionsFromRoot( | ||
svelteAst: SvAST.Ast | SvAST.AstLegacy, | ||
): Compiler.SvelteOptionsRaw | null { | ||
return (svelteAst as any).options?.__raw__ ?? null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I still don't know the correct way to get the <svelte:options>
AST.
I think it's better to merge this after stable Svelte 5 is released? |
I would like to improve the way to get the AST node of |
bb26940
to
be5eecb
Compare
MEMO: |
c87e7a6
to
6ee516a
Compare
svelte 5 is already included in cli tooling so would be good to have this. |
cfb8c50
to
7b8f3a4
Compare
ceb38a8
to
a9a5ac2
Compare
…property, we parse it ourselves
This PR will be changed to also use Svelte v5's modern AST.
I believe this has performance benefits as it allows we to skip the transformation step to legacy AST.