-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tailwindcss
4.0
#422
Conversation
🦋 Changeset detectedLatest commit: 1d452b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hey guys, this is Chris from Skeleton. We're super excited about the Tailwind v4 update as well, but we're preparing to launch our next major release as soon as next week. As such, we have not had a chance to even touch Tailwind v4 yet to ensure Skeleton is compatible. We're using
I know this is very much an "us" problem, but Tailwind is the lifeblood of our project, so a flag to default to Tailwind v3 temporary would no doubt save us from a flood of support tickets! Once we can confirm all is well with v4 then by all means, let's open that floodgate! I'm going to set some time aside to test this tomorrow. Really though, we're down to collaborate on whatever is required to make this happen. Just let me know. Thanks! |
Could you just use a pinned version of |
@benmccann as long as users would get the latest packages for Svelte/SvelteKit that would probably be fine for now. What I'm worried about is we might get in there and realize we have to completely replace our entire Tailwind Plugin to resolve compatibility. That's the worst case scenario and would likely have a long lead time. But I'll have a definitive answer on compatibility tomorrow. I'm going to run through and test our RC version with Tailwind 4 and see how it goes. Ideally it just works and this becomes much ado about nothing! fingers crossed |
Pining sv sounds to be the right solution to me. Plus it's adding a motivation boost 😅💪 |
Ha, well this is the end of a 13 month dev cycle for our new update. It's been a massive undertaking. Not sure if I need motivation, a vacation, or a straight jacket at this point! 😄 But hey, we'll be one of the libraries of this scale with full Svelte 5 support! So there's that! |
While svelte 5 was a big effort, I know that for libs it's also massive ! Congratz' 🚀🚀 |
Hey guys - so a status update on this. A few of us have been testing Tailwind v4 + Skeleton v3 today. Unfortunately the news isn't what we wanted. Let me try to explain the situation as I currently understand it:
So what we do for Skeleton is we use a mix of two approaches:
End users then install our plugin and have access to this vast number of extended classes and feature we provide. You can see most of that documented here. However, Tailwind v4 takes another approach:
The problem with this, is Tailwind v4 doesn't seem to be fully backwards compatible with our plugin. They do allow you to optionally provide a So the plan is to continue to dig into this. See if perhaps there's some sort of bridge we can come up with. But otherwise the Skeleton core package (which is purely our Tailwind plugin) will need to have two separate versions:
While we have every intention on generating that latter option, it will likely have to be the focus of our next major release. This includes a tool to migrate user's theme file from CSS-in-JS format to pure CSS, etc. By my estimate it won't be a trivial change so my ETA is likely weeks, not days. So again I raise the question above - what would be the repercussions of pinning |
Thank you for all these details & info. I have to say that I started this PR more like "Haaa cool, v4 is out, for new projects it could make sense to be on latest". In your doc, if you pin In the end, I let repo owners guide me in giving the direction. |
Completely understand Jean, and I am terribly sorry if I have derailed any progress here. There's obviously plenty of folks that will want to use the latest and greatest version of Tailwind asap. I just wanted to make sure you guys were aware of the impact it could have on us. Mostly this is just bad timing! We've been in crunch mode these last few weeks to polish off this big new update, so we completely missed the Tailwind v4 beta. That's 100% on me. But with a bit more time we'll get to the point we can fully support Tailwind v4. Which Im incredibly excited for. There's so many awesome features and many things will be much simpler for both us and end users. I think we just need more hours in the day to get everything done! Heh |
I'll say this - go ahead and merge whenever you guys are ready. Don't let us hold you back. We'll opt for pinning
|
@benmccann did you get the chance to see my updates ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only have a couple of suggestions. Aside from those, the rest is excellent and should be good to go. Thank you!!
I filed an issue to ask them about plugins. Hopefully they'll be able to share some information. tailwindlabs/tailwindcss-typography#372 |
Co-authored-by: CokaKoala <[email protected]>
commit: |
Thank you everyone for all your work! This looks perfect, and CI is passing! Apart from the discussion around Let's give them a few days so that we can hopefully get a response on the status of those two plugins. If we don't get a meaningful response I think using |
I think that you are not missing anything 👍 |
Just wanna say y'all are awesome. ❤️ |
Quick question: does it work with
{
"tailwindStylesheet": "./src/app.css"
} |
Based on the current state of plugins, and no official timeline provided, let's go with what we have here. As soon as the plugins are officially supported again, we will re-include them. Thanks for all your work @jycouet and all the others for providing feedback! |
oklch