-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chinese pronunciations #85
base: master
Are you sure you want to change the base?
Conversation
For Chinese entries, pronunciation div uses the class 'zhpron'
I've tested that this works. @suyash458 can you consider merging this after @claw89 fixes the conflicts? |
Actually, upon further testing I have found an issue: not all possible pronunciations are fetched. As an example, consider the query word Example:
Output:
|
This issue probably can't be fixed without also addressing #9. |
Fixes #81
The list of pronunciation_div_classes in the function parse_pronunciations was missing the div class used on Chinese entries: "zhpron"