fix(claim_validator): Update the same id claim validator instead of adding a new one

CHANGELOG.md

@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [unreleased]
 
+- Updated the `SessionClaimValidatorStore.addClaimValidatorFromOtherRecipe` function to update the claimValidator to the latest if added again with the same id instead of adding a new claimValidator.
+
 ## [20.1.5] - 2024-10-03
 
 ### Changes

lib/ts/utils/sessionClaimValidatorStore.ts

@@ -19,7 +19,22 @@ export class SessionClaimValidatorStore {
     private static claimValidatorsAddedByOtherRecipes: SessionClaimValidator[] = [];
 
     static addClaimValidatorFromOtherRecipe = (builder: SessionClaimValidator) => {
-        SessionClaimValidatorStore.claimValidatorsAddedByOtherRecipes.push(builder);
+        const existingBuilderIdIndex: number = SessionClaimValidatorStore.claimValidatorsAddedByOtherRecipes.findIndex(
+            claimValidator => claimValidator.id === builder.id
+        );
+
+        /*
+         * Updating the claim validator in the claimValidatorsAddedByOtherRecipes list if the
+         * validator already exists with the same builder id else we push the new builder in
+         * the claimValidatorsAddedByOtherRecipes.
+         * Hence, always the last added claim validator for the recipe will exist in the
+         * claimValidatorsAddedByOtherRecipes list.
+         */
+        if (existingBuilderIdIndex > -1) {
+            SessionClaimValidatorStore.claimValidatorsAddedByOtherRecipes[existingBuilderIdIndex] = builder;
+        } else {
+            SessionClaimValidatorStore.claimValidatorsAddedByOtherRecipes.push(builder);
+        }
     };
 
     static getClaimValidatorsAddedByOtherRecipes = (): SessionClaimValidator[] => {

test/sessionClaimValidator.Store.test.js

@@ -0,0 +1,41 @@
+/* Copyright (c) 2024, VRAI Labs and/or its affiliates. All rights reserved.
+ *
+ * This software is licensed under the Apache License, Version 2.0 (the
+ * "License") as published by the Apache Software Foundation.
+ *
+ * You may not use this file except in compliance with the License. You may
+ * obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ */
+
+const assert = require("assert");
+const { BooleanClaim } = require("../lib/build");
+const { SessionClaimValidatorStore } = require("../lib/build/utils/sessionClaimValidatorStore");
+
+describe("SessionClaimValidatorStore:addClaimValidatorFromOtherRecipe", () => {
+    it("SessionClaimValidatorStore addClaimValidatorFromOtherRecipe should update the existing validator rather than adding new one", function () {
+        const claimFirst = new BooleanClaim({
+            id: "st-test",
+            refresh: () => {},
+            defaultMaxAgeInSeconds: 10
+        });
+
+        const claimSecond = new BooleanClaim({
+            id: "st-test",
+            refresh: () => {},
+            defaultMaxAgeInSeconds: 10
+        });
+
+        SessionClaimValidatorStore.addClaimValidatorFromOtherRecipe(claimFirst);
+        SessionClaimValidatorStore.addClaimValidatorFromOtherRecipe(claimSecond);
+
+        const claimValidators = SessionClaimValidatorStore.getClaimValidatorsAddedByOtherRecipes();
+
+        assert.strictEqual(claimValidators.length, 1);
+    });
+});