-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: improve form validation #919
[WIP] feat: improve form validation #919
Conversation
✅ Deploy Preview for astounding-pegasus-21c111 canceled.
|
✅ Deploy Preview for precious-marshmallow-968a81 canceled.
|
@rishabhpoddar - Need your inputs here:
Thanks. |
Please feel free to add yourself to the readme of the supertokens-core repo |
Hey @akashrajum7 there are two tests that are failing due to the changes made here: https://app.circleci.com/pipelines/github/supertokens/supertokens-node/5985/workflows/cfe50d90-2d11-4f6d-bf95-180345c1235c/jobs/3363 |
Last I ran this locally, everything went through fine, let me check again and open a new PR in case any changes are required, thanks. |
@akashrajum7 we are doing the fix on our end now, since we have to do a release soon, and this is blocking our release. |
@rishabhpoddar Sure, thanks. Would be nice if there was a pre-check on the test cases before the merge passes. |
Summary of change
This PR aims to improve the form field validation in emailpassword to allow for optional form fields to be truly optional and not have to send empty values. It looks like the rest of the recipes use the UserMetadata recipe to store extra information.
Related issues
Test Plan
Added a test case to check the functionality of optional fields missing in the payload does not result in an error
Documentation changes
Not sure which section of the docs talks about the behaviour of optional fields currently, can update there once this implementation is completed
Checklist for important updates
package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.Remaining TODOs for this PR